Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glslang: add missing glslang-default-resource-limits component #24734

Merged
merged 1 commit into from
Jul 29, 2024
Merged

glslang: add missing glslang-default-resource-limits component #24734

merged 1 commit into from
Jul 29, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 27, 2024 •
edited
Loading

Summary

Changes to recipe: glslang/*

Motivation

The glslang-default-resource-limits component is exported by the project but not the recipe. Required for Dawn.

Details

Available since KhronosGroup/glslang@f5fa593 / v1.3.243.0.

@valgur valgur mentioned this pull request Jul 27, 2024
Open
3 tasks
@valgur valgur force-pushed the bugfix/glslang-default-resource-limits branch from 13b1ac5 to 8d26e46 Compare July 27, 2024 13:03
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (8d26e4658c4e0e7a5a803cecea2509d437e26d99):

  • glslang/1.3.268.0:
    All packages built successfully! (All logs)

  • glslang/1.3.261.1:
    All packages built successfully! (All logs)

  • glslang/1.3.239.0:
    All packages built successfully! (All logs)

  • glslang/1.3.243.0:
    All packages built successfully! (All logs)

  • glslang/1.3.236.0:
    All packages built successfully! (All logs)

  • glslang/1.2.198.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (8d26e4658c4e0e7a5a803cecea2509d437e26d99):

  • glslang/1.3.268.0:
    All packages built successfully! (All logs)

  • glslang/1.3.261.1:
    All packages built successfully! (All logs)

  • glslang/1.3.239.0:
    All packages built successfully! (All logs)

  • glslang/1.3.236.0:
    All packages built successfully! (All logs)

  • glslang/1.3.243.0:
    All packages built successfully! (All logs)

  • glslang/1.2.198.0:
    All packages built successfully! (All logs)

@perseoGI perseoGI self-assigned this Jul 29, 2024
perseoGI
perseoGI approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perseoGI perseoGI requested a review from AbrilRBS July 29, 2024 10:00
AbrilRBS
AbrilRBS approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conan-center-bot conan-center-bot merged commit 1958cf2 into conan-io:master Jul 29, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perseoGI perseoGI perseoGI approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@perseoGI perseoGI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valgur @conan-center-bot @AbrilRBS @perseoGI